Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove extra checkout steps in diff actions? #5017

Open
DaughterOfMars opened this issue Jan 24, 2025 · 0 comments
Open

Should we remove extra checkout steps in diff actions? #5017

DaughterOfMars opened this issue Jan 24, 2025 · 0 comments
Labels
dev-tools Issues related to the Developer Tools Team

Comments

@DaughterOfMars
Copy link
Contributor

Description

In the github diff actions (.github/actions/diffs/action.yml and .github/actions/turnbo-diffs/action.yml) there are steps to checkout the repo. However, these are probably unnecessary as it is a requirement for the caller to have already checked out the repo in order to call these actions, as the action files will be unavailable otherwise. This means that we are checking out three times in the hierarchy's diff job.

This does protect against the situation where the caller checks out only, for instance, the .github directory. However, that is a non-issue in my opinion as there are no instances where we do this or have any reason to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tools Issues related to the Developer Tools Team
Projects
None yet
Development

No branches or pull requests

2 participants