Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to update BNS cash configuration #1067

Open
webmaster128 opened this issue Jun 6, 2019 · 6 comments
Open

Add tests to update BNS cash configuration #1067

webmaster128 opened this issue Jun 6, 2019 · 6 comments

Comments

@webmaster128
Copy link
Contributor

webmaster128 commented Jun 6, 2019

Each module can have a Configuration object and a transaction type to update this. For cash this is

Looks like there is only one configuration that can be updated at the moment

@willclarktech
Copy link
Contributor

@webmaster128 Is it definitely just unit tests for this issue or do we need to sort out encoding/decoding of a transaction?

@webmaster128
Copy link
Contributor Author

@willclarktech sorry, unittests -> tests. There should be a test showing that Configuration can be updated. This requires encoding/decoding of the ConfigurationMsg and the new configuration object.

@webmaster128 webmaster128 changed the title Add unittests to update BNS configuration Add tests to update BNS configuration Jun 24, 2019
@willclarktech
Copy link
Contributor

Waiting for app.Tx to be updated, probably in Weave 0.17.1.

@willclarktech willclarktech removed their assignment Aug 13, 2019
@willclarktech
Copy link
Contributor

@webmaster128 What's the current status of this issue. Should we add it to 1.0?

@webmaster128
Copy link
Contributor Author

@willclarktech I'd not consider it a blocker for 1.0.0, but as far as I can see it is ready for development. I moved it to position 1 in the backlog

@willclarktech willclarktech self-assigned this Sep 25, 2019
@willclarktech
Copy link
Contributor

Blocked by iov-one/weave#815 which is scheduled for post-MVP.

@willclarktech willclarktech removed their assignment Sep 25, 2019
@webmaster128 webmaster128 changed the title Add tests to update BNS configuration Add tests to update BNS cash configuration Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants