Add reconnected handler to tendermint websocket client #1201
Conversation
willclarktech
force-pushed
the
1200-client-reconnected-handler
branch
from
2f7b752 to
9352aa1
Compare
| const request = createJsonRpcRequest("subscribe", { query: query }); | ||
| const producer = new RpcEventProducer(request, this.socket); | ||
| const stream = Stream.create(producer); | ||
| this.subscriptionStreams.set(query, stream); |
There was a problem hiding this comment.
This sets subscriptionStreams[subscriptionStreams] to a new reference. The old stream the caller got via const eventStream = this.client.listen(req); will not change, so the new events do not arrive.
Also this re-establishes subscribtions that nobody listens to anymore (where the original producer was stopped).
My feeling is that in public listen(request: JsonRpcRequest): Stream<SubscriptionEvent> { there needs to be a producer (maybe a wrapper around RpcEventProducer) which survives the reconnect and routes events from different sources.
willclarktech
force-pushed
the
1200-client-reconnected-handler
branch
from
9352aa1 to
9b03cad
Compare
| @@ -131,6 +131,40 @@ class RpcEventProducer implements Producer<SubscriptionEvent> { | |||
| } | |||
| } | |||
|
|
|||
| class ReconnectingRpcEventProducer implements Producer<SubscriptionEvent> { | |||
| public stopped: boolean = false; | |||
There was a problem hiding this comment.
this can become private, right?
There was a problem hiding this comment.
Yes, thanks, I originally had the check outside the class.
|
@webmaster128 I’ll have a think about tests and then convert this to a non-draft PR. |
willclarktech
force-pushed
the
1200-client-reconnected-handler
branch
8 times, most recently
from
86cff85 to
a1c20f0
Compare
willclarktech
force-pushed
the
1200-client-reconnected-handler
branch
from
a1c20f0 to
cf1fb7c
Compare
Closes #1200
I’m a little unclear on the acceptance criteria for this issue, so opening this draft PR now to get feedback. Is this basically what we need or is there something I’ve missed?