Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

fix: update to unzip-stream #27

Merged
merged 5 commits into from
May 4, 2018
Merged

fix: update to unzip-stream #27

merged 5 commits into from
May 4, 2018

Conversation

hacdias
Copy link
Contributor

@hacdias hacdias commented May 4, 2018 •
edited
Loading

Fixes #24

@ghost ghost assigned hacdias May 4, 2018
@ghost ghost added the status/in-progress In progress label May 4, 2018
@hacdias
Copy link
Contributor Author

hacdias commented May 4, 2018

@victorbjelkholm just like we did in npm-go-ipfs, should we move this to Jenkins only? 😄 This doesn't use Aegir either.

@victorb
Copy link

victorb commented May 4, 2018

@hacdias sure! I'll remove CircleCI and TravisCI and you can add the Jenkinsfile, as soon as it's there, Jenkins should pick up the job automatically.

@victorb
Copy link

victorb commented May 4, 2018

Ok, circle + travis has been disabled!

@hacdias
Copy link
Contributor Author

hacdias commented May 4, 2018

Thanks @victorbjelkholm

@hacdias hacdias requested review from daviddias and victorb May 4, 2018 10:15
@hacdias hacdias changed the title update to unzip-stream fix: update to unzip-stream May 4, 2018
daviddias
daviddias approved these changes May 4, 2018
View reviewed changes
Copy link
Contributor

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hacdias <3

@daviddias daviddias merged commit d3acfd7 into master May 4, 2018
@ghost ghost removed the status/in-progress In progress label May 4, 2018
@daviddias daviddias deleted the unzip branch May 4, 2018 10:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

@victorb victorb Awaiting requested review from victorb

Assignees

@hacdias hacdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacdias @victorb @daviddias