Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to load current Kubo and run loopback tests #22

Open
erikmav opened this issue Apr 8, 2023 · 3 comments
Open

Update CI to load current Kubo and run loopback tests #22

erikmav opened this issue Apr 8, 2023 · 3 comments

Comments

@erikmav
Copy link

erikmav commented Apr 8, 2023

The current TestFixture.Ipfs implementation for running unit tests currently just creates an IpfsClient instance with the assumption of an IPFS local server to connect to. Update the test code to:

Note this item will probably illuminate a lot of missing or out of date functionality. File incompatibilities as new issues.

@erikmav
Copy link
Author

erikmav commented Apr 8, 2023

@Arlodotexe possible to add me as a contributor on this repo to be able to run CI? Also on IpfsCore as both repos need simultaneous updating.

@Arlodotexe
Copy link
Collaborator

Arlodotexe commented Apr 17, 2023

This part of Richard's tests always bothered me a bit. I noticed this the first time I ported his code over. It wasn't a simple fix, so I moved on and worked on developing tooling to make this easier.

I'm actually using that tooling in my own apps and unit tests, dogfooding it. Specifically, we'll want to make use of KuboDownloader and KuboBootstrapper if there's no HTTP API already running.

Note If our test project takes this new dependency, Arlodotexe/OwlCore.Kubo#3 gets a priority bump, but isn't required to close this ticket.

@Arlodotexe
Copy link
Collaborator

Arlodotexe commented Apr 11, 2024

To give an update on this.

We're still doing various API cleanup to get us aligned with the most recent version of Kubo. Until we've finished fixing all remaining discrepancies, our unit tests won't fully pass.

When we've made more progress, we'll get Kubo bootstrapped and running as part of the tests, and run it in the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants