Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: extract CORS to headers middleware #569

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jan 18, 2024

To help with ipshipyard/waterworks-community#4. Sharness won't pass here because Kubo won't build.

Kubo PR: ipfs/kubo#10311

@hacdias hacdias self-assigned this Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4c3a1f2) 65.58% compared to head (253640e) 65.61%.

❗ Current head 253640e differs from pull request most recent head 19948a2. Consider uploading reports for the commit 19948a2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   65.58%   65.61%   +0.02%     
==========================================
  Files         206      207       +1     
  Lines       25587    25589       +2     
==========================================
+ Hits        16781    16789       +8     
+ Misses       7335     7330       -5     
+ Partials     1471     1470       -1     
Files Coverage Δ
examples/gateway/common/handler.go 95.40% <100.00%> (-0.16%) ⬇️
gateway/gateway.go 75.94% <ø> (-9.10%) ⬇️
gateway/handler.go 76.46% <ø> (-0.25%) ⬇️
gateway/headers.go 100.00% <100.00%> (ø)
gateway/hostname.go 73.02% <33.33%> (-0.38%) ⬇️

... and 10 files with indirect coverage changes

@hacdias hacdias marked this pull request as ready for review January 22, 2024 15:22
@hacdias hacdias requested review from lidel and a team as code owners January 22, 2024 15:22
@hacdias hacdias changed the title gateway: new headers middleware gateway: extract CORS to headers middleware Jan 22, 2024
gateway/headers.go Outdated Show resolved Hide resolved
Co-authored-by: Marcin Rataj <[email protected]>
@hacdias hacdias merged commit 3d57bce into main Jan 24, 2024
11 of 12 checks passed
@hacdias hacdias deleted the headers-middleware branch January 24, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants