Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port all "simple" sharness tests #26

Closed
20 tasks done
Tracked by #8
laurentsenta opened this issue Mar 27, 2023 · 3 comments · Fixed by #92
Closed
20 tasks done
Tracked by #8

Port all "simple" sharness tests #26

laurentsenta opened this issue Mar 27, 2023 · 3 comments · Fixed by #92
Assignees
Labels
test:coverage Improves the spec covered by this test suite

Comments

@laurentsenta
Copy link
Contributor

laurentsenta commented Mar 27, 2023

#3 relies on #22 and #10 which requires new features / larger tasks.

In parallel, we'll push more tests to the test suite to support bifrost

Other tests implemented along other tickets:

follow-up tasks

@galargh
Copy link
Contributor

galargh commented Apr 3, 2023

@laurentsenta I'm going to try to pick up t0116-gateway-cache.sh. I'll report at the end of the day what the status is.

@BigLep BigLep moved this to 🏃‍♀️ In Progress in IPFS Shipyard Team May 11, 2023
@BigLep
Copy link

BigLep commented Jun 19, 2023

@laurentsenta : is the checklist accurate of what's remaining? There look to be unchecked things that are merged and #30 (comment) was unclear to me whether that PR is going to be merged.

I am asking because I'm trying to get a sense of what's remaining and where others need to help review so we can close this. Thanks.

@laurentsenta laurentsenta added the test:coverage Improves the spec covered by this test suite label Jun 26, 2023
@laurentsenta
Copy link
Contributor Author

@BigLep the ticket is up to date now, we'll tackle 116 in a follow-up task, I really want to move on with all of these.

We were missing one last pass to double-check that everything was ported correctly, and remove the "wip" comments,
PR: #92

@github-project-automation github-project-automation bot moved this from 🤔 Triage to 🥳 Done in InterPlanetary Developer Experience Jun 30, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In Progress to 🎉 Done in IPFS Shipyard Team Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:coverage Improves the spec covered by this test suite
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants