-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dnslink support and update t0109 #34
Conversation
1ee3082
to
560bbea
Compare
560bbea
to
266cdb6
Compare
279e24a
to
d2757ba
Compare
a40f2e0
to
9fd3ab5
Compare
66a3982
to
0fa2fe7
Compare
928d79d
to
ed96dd0
Compare
ed96dd0
to
fbce0ea
Compare
failing test on purpose: https://github.com/ipfs/gateway-conformance/actions/runs/4924297430 |
3933b9e
to
1be71ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking 🥇
1be71ab
to
83c417c
Compare
# yaml-language-server: $schema=fixture.schema.json | ||
dnslinks: | ||
custom-dnslink: | ||
subdomain: dnslink-enabled-on-fqdn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(github was down and missed oportunity to review earlier)
@laurentsenta i am bit confused – whgy is this "subdomain" specific?
DNSLink TXT records can be present on subdomains OR the top domains right after TLD.
Should this be renamed to fqdn
or plain domain
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(github was down and missed oportunity to review earlier)
👍 thanks for reviewing anyway; happy to fix if the approach is lacking, @hacdias had a similar question when we reviewed it.
DNSLink TXT records can be present on subdomains OR the top domains right after TLD.
We want to configure the top domain + tld during test EXECUTION, not at test definition: two users might run that test on different subdomain gateway URLs, example.com
and dweb.link
for example.
This means we want to be able to construct URLs with {dns-link.subdomain}.{gateway_url}
at run time (actual code).
Thinking about it, I guess we might want to define a fqdn/domain, like
dnslinks:
wikipedia:
domain: wikipedia-on-ipfs.org
path: /ipfs/somethingsomething
but that would be a different test, we do need to keep the subdomain
option to port most of the tests like 114 and 109.
That's my understanding so far, let me know if I'm missing something!
Contributes to #26
Closes #22
This tests adds dnslink support:
We introduce a fixture type which contains a dnslink configuration:
Test writer uses the fixture with:
Test user calls the
export
CLI to get the yml files. We also generate a dnslinks.json.There is a demo in
kubo-config.example.sh
that shows how to import the fixtures:Todo