Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dnslink support and update t0109 #34
feat: add dnslink support and update t0109 #34
Changes from all commits
c5f96f2
c6928ae
cf14faf
9f908f5
566f481
8c31b06
b51d4e3
c3bc2ef
83c417c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(github was down and missed oportunity to review earlier)
@laurentsenta i am bit confused – whgy is this "subdomain" specific?
DNSLink TXT records can be present on subdomains OR the top domains right after TLD.
Should this be renamed to
fqdn
or plaindomain
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks for reviewing anyway; happy to fix if the approach is lacking, @hacdias had a similar question when we reviewed it.
We want to configure the top domain + tld during test EXECUTION, not at test definition: two users might run that test on different subdomain gateway URLs,
example.com
anddweb.link
for example.This means we want to be able to construct URLs with
{dns-link.subdomain}.{gateway_url}
at run time (actual code).Thinking about it, I guess we might want to define a fqdn/domain, like
but that would be a different test, we do need to keep the
subdomain
option to port most of the tests like 114 and 109.That's my understanding so far, let me know if I'm missing something!