Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work when with virtualbox shared volumes #28

Open
Stebalien opened this issue Feb 17, 2018 · 0 comments
Open

Doesn't work when with virtualbox shared volumes #28

Stebalien opened this issue Feb 17, 2018 · 0 comments

Comments

@Stebalien
Copy link
Member

Stebalien commented Feb 17, 2018

Basically, we try to sync a directory, windows fails with "invalid argument" (windows doesn't support syncing directories) and vbox forwards this error.

We actually have a check to avoid syncing directories on windows. Unfortunately... in this case, we think we're on Linux. I believe the correct fix is to detect that the error is an "invalid argument" error and ignore it (we can't sync anyways, nothing really failed).


Edit: It turns out that vboxsf just doesn't support fsync on directories at all. Really, we probably should just be ignoring fsync errors on directories entirely (possibly logging them?). There's not much we can do anyways.

@Stebalien Stebalien changed the title Doesn't work when with virtualbox volumes (at last when used by docker) on Windows Doesn't work when with virtualbox shared volumes Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant