Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Refactor #1214

Open
whizzzkid opened this issue Jun 1, 2023 · 0 comments
Open

[Enhancement] Refactor #1214

whizzzkid opened this issue Jun 1, 2023 · 0 comments
Labels
exp/expert Having worked on the specific codebase is important kind/architecture Core architecture of project kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@whizzzkid
Copy link
Contributor

Refactor createIpfsCompanion to have a simpler version. Background service-worker creates the companion instance and also the quick-import tries to do the same here, it creates some issues with reloaders and how contextMenus are built. Especially in the MV3 world where the global listener is a thing.

Also, tackle testing this effectively.
@whizzzkid whizzzkid added kind/enhancement A net-new feature or improvement to an existing feature exp/expert Having worked on the specific codebase is important P3 Low: Not priority right now kind/architecture Core architecture of project labels Jun 1, 2023
@whizzzkid whizzzkid mentioned this issue Jun 1, 2023
Merged
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important kind/architecture Core architecture of project kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Needs Grooming
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whizzzkid