Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bonding plugin fails to move VLAN subinterfaces to bond #1802

Open
jbemmel opened this issue Jan 13, 2025 · 1 comment
Open

[BUG] Bonding plugin fails to move VLAN subinterfaces to bond #1802

jbemmel opened this issue Jan 13, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jbemmel
Copy link
Collaborator

jbemmel commented Jan 13, 2025

The bonding plugin needs more work in combination with VLANs, the following does not work correctly:

plugin: [ bonding ]

vlans:
  v1:

groups:
 _auto_create: True
 nodes:
  members: [ n1, n2, n3 ]
  device: frr
  module: [ vlan ]

links:
- n1:
   bonding.ifindex: 1
  n2:
  vlan.trunk: [ v1 ]
- n1:
   bonding.ifindex: 1
  n3:
  vlan.trunk: [ v1 ]

Need to create integration test cases for the basic use case with Linux hosts, and the VLAN case

@jbemmel jbemmel added the bug Something isn't working label Jan 13, 2025
@jbemmel jbemmel self-assigned this Jan 13, 2025
@ipspace
Copy link
Owner

ipspace commented Jan 13, 2025

It might be worth remembering that VLANs sit above bonding in the protocol stack, so the VLAN subinterfaces should not be created out of the member links.

I would suggest you limit the bonding (non-LAG) functionality to links without VLAN encapsulation (= access links but not trunks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants