Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow and runner instrumentation and traces #457

Open
5 tasks
Tracked by #184
bgins opened this issue Nov 29, 2023 · 0 comments
Open
5 tasks
Tracked by #184

Add workflow and runner instrumentation and traces #457

bgins opened this issue Nov 29, 2023 · 0 comments
Labels
workflows Related to IPVM workflows

Comments

@bgins
Copy link
Contributor

bgins commented Nov 29, 2023

Summary

Let's add workflow instrumentation and tracing to track more information about workflow runs.

Detail

We should add instrumentation and tracing to determine:

  • Total runs for a workflow
  • Total ok/errors within a workflow run
  • Total tasks replayed within a workflow
  • Time spent running a workflow
  • Time spent running tasks within a workflow
@bgins bgins added the workflows Related to IPVM workflows label Nov 29, 2023
@bgins bgins mentioned this issue Nov 29, 2023
Open
4 tasks
@bgins bgins mentioned this issue Mar 7, 2024
Merged
7 tasks
bgins added a commit that referenced this issue Mar 13, 2024
@bgins
refactor: Add workflow spans and every cli logging (#603)
c3f9b4a 
# Description

This PR implements the following changes:

- [x] Add initial workflow and task execution spans
- [x] Add workflow initialize, start, and end logs
- [x] Add computed and replayed receipt logs
- [x] Add custom logging format and filter for EveryCLI
- [x] Minor re-wording of existing logs

## Link to issue

Implements spans needed in #457

## Type of change

- [x] New feature (non-breaking change that adds functionality)
- [x] Refactor (non-breaking change that updates existing functionality)

## Test plan (required)

Run Homestar with `EVERY_CLI` set to `true` to see the simplified logs:

```
EVERY_CLI=true cargo run -- start
```

Check that `RUST_LOG` works when `EVERY_CLI` is `false` or not set:

 ```
EVERY_CLI=false RUST_LOG=info cargo run -- start
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
workflows Related to IPVM workflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bgins