Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Network notifications #631

Open
bgins opened this issue Apr 1, 2024 · 0 comments
Open

Refactor: Network notifications #631

bgins opened this issue Apr 1, 2024 · 0 comments
Labels
networking Features, functionality involving networking

Comments

@bgins
Copy link
Contributor

bgins commented Apr 1, 2024

Summary

Our network notifications take an intermediate step by converting to primitive types before converting to IPLD.

Impact

Performance cost and some added complexity.

Solution

Remove the intermediate representations.

Detail

This refactor will require that we can reconstitute libp2p data structures from IPLD. We should investigate where this is possible, but we could partially refactor even if it is not possible in all cases.

Note that this would also require updates to JSON Schemas to report the serialized types that clients should expect.

@bgins bgins added the networking Features, functionality involving networking label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
networking Features, functionality involving networking
Projects
None yet
Development

No branches or pull requests

1 participant