Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distill procedure: create student model #4

Open
BomboButt opened this issue Apr 21, 2018 · 1 comment
Open

Distill procedure: create student model #4

BomboButt opened this issue Apr 21, 2018 · 1 comment

Comments

@BomboButt
Copy link

Dear @irapha:
When create student model,
this line
https://github.com/iRapha/replayed_distillation/blob/943169e3b37f5453b386ae652af81db935efc7bd/procedures/distill.py#L28

shouldn't it be like:
outputs, _, feed_dicts = m.get(f.student_model).create_model(inputs_reshape, output_size)

@irapha
Copy link
Owner

irapha commented Apr 23, 2018

Hm, I remember there being something weird about the way tensorflow was loading models that made something be unintuitive in the way flags worked. So there's a chance that this is correct as is. Unfortunately, I don't remember exactly what the unintuitive thing is (it's been a year since I wrote this code).

The codebase also went through major refactoring right before we released it, so there's also a chance that this should, in fact, be student_model.

Do you see it not working the way it is? Does changing this fix it? If so, please let me know and I'll fix it here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants