Add a test for training MNIST on CUDA and CPU that verifies same result as Jax #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sogartar
force-pushed
the
mnist-train-test
branch
4 times, most recently
from
83f9e31
to
77fbd83
Compare
sogartar
force-pushed
the
mnist-train-test
branch
2 times, most recently
from
5dce0e9
to
2592d0a
Compare
|
is there a way to get a test independent of JAX? If you don't have a simple way I'll try to make one later |
…t as Jax The two tests fail for different reasons. Things work OK except the procedure to initialize the optimizer.
sogartar
force-pushed
the
mnist-train-test
branch
from
2592d0a
to
4e4d641
Compare
rsuderman
approved these changes
Feb 1, 2023
wangkuiyi
reviewed
Feb 3, 2023
| return next(batches) | ||
|
|
||
|
|
||
| def get_model(): |
There was a problem hiding this comment.
Thank you @sogartar for this pull request! It seems that this function duplicates with the one
iree-jax/examples/mnist_export.py
Lines 61 to 69 in 26006ef
There was a problem hiding this comment.
Yes, I copied the model from there. I guess mnist_export.py example can benefit from a test too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two tests fail for different reasons. Things work OK except the procedure to initialize the optimizer.