Rename matmul/ to linalg_ops/, rebase IREE, add test workflow. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
force-pushed
the
matmul-to-linalg
branch
from
9721450 to
88f95ba
Compare
ScottTodd
force-pushed
the
matmul-to-linalg
branch
from
88f95ba to
b56593b
Compare
saienduri
reviewed
Sep 4, 2024
| ctest \ | ||
| --test-dir build/ \ | ||
| -R iree-test-suites \ | ||
| --label-exclude "^driver=vulkan$|^driver=metal$|^driver=cuda$|^driver=hip$" |
There was a problem hiding this comment.
Any reason, we don't run on hip too?
There was a problem hiding this comment.
Just using a standard GitHub runner with no GPU for this workflow. Latest, we can run these tests here on any runners we want and/or we can fetch the tests from the IREE repo and run there using code from PRs (see iree-org/iree#18291 for a proof of concept)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #2.
matmul/folder tolinalg_ops/. We can putconvolution(linalg) andattention(linalg_ext) tests under here too. Maybe other named ops or generics too.linalg_ops/README.mdand configured both workflows to run onpushevents in addition to the current triggers.