Add evoformer example #289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-nod
force-pushed
the
evoformer
branch
3 times, most recently
from
165c51c
to
da1931f
Compare
raikonenfnu
reviewed
Nov 22, 2024
Comment on lines
+13
to
+14
| WORKGROUP_3 = index_symbol("$WG3") | ||
| WORKGROUP_4 = index_symbol("$WG4") |
There was a problem hiding this comment.
Doesn't the GPU typically only have 3 dims? 😆
There was a problem hiding this comment.
They do :) This is just to keep it easier for the kernel author. All workgroup dimensions >= 2 are obtained by delinearizing workgroup id z.
harsh-nod
force-pushed
the
evoformer
branch
5 times, most recently
from
7aee493
to
af5e9e8
Compare
Signed-off-by: Harsh Menon <[email protected]>
harsh-nod
force-pushed
the
evoformer
branch
2 times, most recently
from
261892b
to
6c8f6c7
Compare
Signed-off-by: Harsh Menon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sample evoformer kernel. To get this to be functional, the following changes were needed