-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Python wheels following TF[Lite] importer changes #13483
Comments
Option B, merging both into iree-tools-tf, seems the right thing. We can't introduce TF dependencies to the compiler. |
Sorry just caught up with this since the IREE nightly release finally has this change. We need to update https://openxla.github.io/iree/getting-started/tflite/#using-command-line-tools if it is assumed tensorflow python package is installed. The alternative is to add tensorflow in The
Please advise on the proper flow to set the wheels up. |
The current source of truth for what dependencies is required is https://github.com/openxla/iree/blob/main/integrations/tensorflow/test/requirements.txt (as of May 9 2023, that is |
Understood. In that case, in the webdoc https://openxla.github.io/iree/getting-started/tflite/#prerequisites should also include tensorflow (or point to the requirments.txt). Is that correct? |
Yep. Maybe we should just include |
Follow-up to iree-org#13068. This path has been unused, and IREE natively supports importing from StableHLO now. The `iree-tools-tf` and `iree-tools-tflite` packages still exist, though they are now tiny pure python packages that could be merged into a single package (see iree-org#13483).
Follow-up to iree-org#13068. This path has been unused, and IREE natively supports importing from StableHLO now. The `iree-tools-tf` and `iree-tools-tflite` packages still exist, though they are now tiny pure python packages that could be merged into a single package (see iree-org#13483).
Follow-up to iree-org#13068. This path has been unused, and IREE natively supports importing from StableHLO now. The `iree-tools-tf` and `iree-tools-tflite` packages still exist, though they are now tiny pure python packages that could be merged into a single package (see iree-org#13483).
Follow-up to iree-org#13068. This path has been unused, and IREE natively supports importing from StableHLO now. The `iree-tools-tf` and `iree-tools-tflite` packages still exist, though they are now tiny pure python packages that could be merged into a single package (see iree-org#13483).
Addding specific tensorflow package due to iree-org/iree#13483. Change-Id: I3458ec9b72442e4efd03772d78f317c3c0ffdc03 GitOrigin-RevId: 8d1e2dc74e2f2a95a43e80280a6b75cd24cd857d
Follow-up to iree-org#13068. This path has been unused, and IREE natively supports importing from StableHLO now. The `iree-tools-tf` and `iree-tools-tflite` packages still exist, though they are now tiny pure python packages that could be merged into a single package (see iree-org#13483).
I'm wondering if we'll want to keep the I haven't seen or heard that much about either framework lately, but TFLite/LiteRT is still in use in a few spots (like #19402). |
I'm now thinking option A ("Merge all |
Following the work in #13037 and other issues/PRs, our TensorFlow and TensorFlow Lite importers are now pure Python packages/scripts, with no direct C++ dependencies on TensorFlow. As a result, our
iree_tools_tf
andiree_tools_tflite-*.whl
Python wheels are now significantly simpler to build and smaller in size (~50MB before -> ~30KB after). We also no longer have airee_tools_xla-*.whl
package.I'd like to take this chance to see if we can further simplify or restructure our released Python packages.
I was also looking at adding badges to our repo README like these:
![PyPI](https://camo.githubusercontent.com/79772e0bc820e2e81a6c7490c5bbb5d5ba4cf2a8f51b27bef97c14658b64fbfc/68747470733a2f2f696d672e736869656c64732e696f2f707970692f762f697265652d636f6d70696c65723f6c6162656c3d697265652d636f6d70696c6572)
for those, it would be nice to have a smaller list (ideally just one package).
Some ideas:
A: Merge all
iree_tools_*
packages intoiree_compiler
Include the Python sources for the TF/TFLite tools in the main package, but make them optional by adding checks around code like this:
https://github.com/openxla/iree/blob/060616cea34d062434097db155c458edb814e235/integrations/tensorflow/python_projects/iree_tf/iree/tools/tf/scripts/iree_import_tf/__main__.py#L60-L72
Pros:
Cons:
B: Merge just
iree_tools_tf
andiree_tools_tflite
These packages are small and similar enough that they could be merged. If they have the same requirements (
tensorflow
/tf-nightly
), is there any harm in merging them?The text was updated successfully, but these errors were encountered: