From a33051f1adbeefc16f6362e171782df6de73f36d Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 6 Sep 2021 13:01:08 +0530 Subject: [PATCH] Fixed skills progress bar --- src/api/index.js | 5 ++++- src/components/Languages/Language.js | 7 ++++--- src/hooks/usePercent.js | 7 +++---- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/api/index.js b/src/api/index.js index 4bf5a35..9b77c29 100644 --- a/src/api/index.js +++ b/src/api/index.js @@ -55,4 +55,7 @@ const getRepos = async (nam) => { } }; -export { getUsers, getRepos, getOrgs, sortByStar }; +const maxPercent=(skills)=>{ + return Math.max.apply(Math, skills.map(function(o) { return o.percent; })) +} +export { getUsers, getRepos, getOrgs, sortByStar,maxPercent }; diff --git a/src/components/Languages/Language.js b/src/components/Languages/Language.js index 595fd9a..c7bfa5b 100644 --- a/src/components/Languages/Language.js +++ b/src/components/Languages/Language.js @@ -1,9 +1,9 @@ import React from 'react' import { Col, ProgressBar, Row } from 'react-bootstrap' import { usePercent } from '../../hooks/usePercent' - +import {maxPercent} from '../../api/index' const Language = ({ id }) => { - const {skills,total,max} = usePercent(id); + const {skills,total} = usePercent(id); return ( @@ -15,7 +15,8 @@ const Language = ({ id }) => { {/* skill-badge */} + max={Math.round(maxPercent(skills)*100/total)}/> + {/* max={Math.round(max*100/total)}/> */} ))} diff --git a/src/hooks/usePercent.js b/src/hooks/usePercent.js index af7290c..bdb159b 100644 --- a/src/hooks/usePercent.js +++ b/src/hooks/usePercent.js @@ -5,7 +5,6 @@ import axios from 'axios' export const usePercent = (id) => { const [total, setTotal] = useState(0) const [skills, setSkills] = useState([]) - const [max,setMax] = useState(0) useEffect(() => { getRepos(id).then(repos => { @@ -25,10 +24,10 @@ export const usePercent = (id) => { }); } }); + setSkills(languages) - setMax(Math.max.apply(Math, skills.map(function(o) { return o.percent; }))) }).catch(err => console.log(err)); - }, [id,skills]) - return {skills,total,max} + }, [id]) + return {skills,total} } \ No newline at end of file