Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dedicated top-level pages per challenge #2437

Merged
merged 41 commits into from
Jan 17, 2025

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Nov 29, 2024

Resolves #2421

Create new top-level challenge pages to (in particular) better group AGC / IDAP projects.

@alexander-held alexander-held marked this pull request as draft November 29, 2024 09:53
@oshadura oshadura force-pushed the refactor/challenges branch from 058e57a to d6bf17a Compare November 29, 2024 17:24
@oshadura
Copy link
Member

Screenshot 2024-12-10 at 15 25 13

@rct225 I tried to rebuild and it looks the same for me :-(

@rct225
Copy link
Collaborator

rct225 commented Dec 10, 2024

Are we ready to push this out?

@matthewfeickert
Copy link
Member

Are we ready to push this out?

I would assume no, given @oshadura's comment #2437 (comment).

@rct225
Copy link
Collaborator

rct225 commented Dec 11, 2024

Ah … misread it.

@oshadura
Copy link
Member

oshadura commented Jan 6, 2025

Screenshot 2025-01-06 at 15 22 17

@rct225
Copy link
Collaborator

rct225 commented Jan 14, 2025

@alexander-held @oshadura I was trying a few things to get the page to build. One question I have was do we want to force all publications to have a challenge-area? I commented the block out requiring it in getpub.rb since most of the YML files for publication do not have an entry for challenge-area.

@oshadura
Copy link
Member

Hi @rct225! Thank a lot, now it looks like finally works as we wanted! There is tiny rendering issue, but otherwise perfect!
Screenshot 2025-01-15 at 14 23 34

@rct225
Copy link
Collaborator

rct225 commented Jan 15, 2025

Happy to help!

@oshadura oshadura force-pushed the refactor/challenges branch from e0a04b9 to 4bcf2b0 Compare January 16, 2025 10:54
@oshadura
Copy link
Member

oshadura commented Jan 16, 2025

@rct225 could I ask you please to take a look (if you will have time) how to add presentations as well to list?
That will fix rendering issue and then after we should be ready to merge it 🥇

Typo - "challenge_area" instead of "challenge_areas" in presentation definition block
@rct225
Copy link
Collaborator

rct225 commented Jan 16, 2025

@oshadura @alexander-held I think I fixed the problem with my latest update. Seems to work.

rct225 and others added 2 commits January 16, 2025 18:33
Added "training-grand-challenge" just for completeness
@oshadura oshadura force-pushed the refactor/challenges branch from 6a1e29d to 24007a5 Compare January 17, 2025 10:01
@oshadura
Copy link
Member

@rct225 @alexander-held now it looks perfect!
(I just improved a bit rendering of web-page, some divs were overlapping for me and I could see some content).

Screenshot 2025-01-17 at 10 58 03 Screenshot 2025-01-17 at 10 57 52

@oshadura
Copy link
Member

@rct225 I think we can merge it and we will finish updating presentations/publications in the next iteration.

@alexander-held alexander-held marked this pull request as ready for review January 17, 2025 10:28
Copy link
Member Author

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you very much! This looks all good from my side.

@rct225 rct225 merged commit fe05a9a into iris-hep:master Jan 17, 2025
2 checks passed
@alexander-held alexander-held deleted the refactor/challenges branch January 21, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create project on website for the 200 Gbps challenge
4 participants