-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dedicated top-level pages per challenge #2437
Conversation
058e57a
to
d6bf17a
Compare
Adding challenge-area to object properties
f91f9c1
to
9eaaacd
Compare
![]() @rct225 I tried to rebuild and it looks the same for me :-( |
Are we ready to push this out? |
I would assume no, given @oshadura's comment #2437 (comment). |
Ah … misread it. |
Forgive me is this is a dumb question. Do we want to force every publication to have a challenge-area? What about puts that existed before the challenges?
@alexander-held @oshadura I was trying a few things to get the page to build. One question I have was do we want to force all publications to have a challenge-area? I commented the block out requiring it in getpub.rb since most of the YML files for publication do not have an entry for challenge-area. |
Hi @rct225! Thank a lot, now it looks like finally works as we wanted! There is tiny rendering issue, but otherwise perfect! |
Happy to help! |
e0a04b9
to
4bcf2b0
Compare
@rct225 could I ask you please to take a look (if you will have time) how to add presentations as well to list? |
Typo - "challenge_area" instead of "challenge_areas" in presentation definition block
@oshadura @alexander-held I think I fixed the problem with my latest update. Seems to work. |
Added "training-grand-challenge" just for completeness
6a1e29d
to
24007a5
Compare
@rct225 @alexander-held now it looks perfect! ![]() ![]() |
@rct225 I think we can merge it and we will finish updating presentations/publications in the next iteration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you very much! This looks all good from my side.
Resolves #2421
Create new top-level challenge pages to (in particular) better group AGC / IDAP projects.