Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create event handler method for S3 keypair #264

Open
alanking opened this issue Sep 11, 2024 · 1 comment
Open

Create event handler method for S3 keypair #264

alanking opened this issue Sep 11, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@alanking
Copy link
Collaborator

alanking commented Sep 11, 2024

Currently, irods_sync script has an --s3_keypair option which must point to a file with an S3 keypair. We should turn this into an event handler method so that the options for getting S3 keypairs for S3 scans can be expanded. Maybe something like this...

@staticmethod
def s3_keypair(meta):
    return "<S3_ACCESS_KEY>", "<S3_SECRET_KEY>"

This will allow the client to implement whatever means necessary to get S3 credentials. However the access key and secret key are acquired is an implementation decision, ultimately returning 2 strings to use with the S3 client in the ingest tool.

The meta argument could be useful to give some context around the job being performed.

@alanking alanking added the enhancement New feature or request label Sep 11, 2024
@trel
Copy link
Member

trel commented Sep 11, 2024

Love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants