Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

S3_copy_object_range errors on x-amz-metadata-directive: REPLACE #6

Closed
2 tasks done
JustinKyleJames opened this issue Sep 22, 2020 · 2 comments
Closed
2 tasks done

S3_copy_object_range errors on x-amz-metadata-directive: REPLACE #6

JustinKyleJames opened this issue Sep 22, 2020 · 2 comments
Assignees
@JustinKyleJames
Labels
bug

Comments

@JustinKyleJames
Copy link

JustinKyleJames commented Sep 22, 2020 •
edited by trel
Loading

  • v4
  • master

It seems to work if I comment the following out.

libs3/src/request.c

Lines 405 to 407 in 59b6237

if (properties) {
headers_append(1, "%s", "x-amz-metadata-directive: REPLACE");
}

trel pushed a commit to JustinKyleJames/libs3 that referenced this issue Dec 5, 2020
@JustinKyleJames @trel
[irods#6] removed x-amz-metadata-directive which was erroring out
eb7c737
trel pushed a commit that referenced this issue Dec 5, 2020
@JustinKyleJames @trel
[#6] removed x-amz-metadata-directive which was erroring out
a84124c
trel pushed a commit to trel/libs3 that referenced this issue Dec 5, 2020
@JustinKyleJames @trel
[irods#6] removed x-amz-metadata-directive which was erroring out
f8b2020
trel pushed a commit to trel/libs3 that referenced this issue Dec 5, 2020
@JustinKyleJames @trel
[irods#6] removed x-amz-metadata-directive which was erroring out
a8241a3
@trel
Copy link
Member

trel commented Dec 7, 2020

This has been in the upstream libs3 since 2008 (and is still there) - so we probably should NOT remove it.

Need to understand what is erroring out.

@JustinKyleJames
Copy link
Author

See the following issue. bji#80

trel pushed a commit to trel/libs3 that referenced this issue Dec 7, 2020
@JustinKyleJames @trel
[irods#6] Only send x-amz-metadata-directive on CopyObject
41f6b98 
See:
  https://docs.aws.amazon.com/AmazonS3/latest/API/API_CopyObject.html
  and
  https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPartCopy.html
trel pushed a commit that referenced this issue Dec 8, 2020
@JustinKyleJames @trel
[#6] Only send x-amz-metadata-directive on CopyObject
07f4478 
See:
  https://docs.aws.amazon.com/AmazonS3/latest/API/API_CopyObject.html
  and
  https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPartCopy.html
@trel trel added the bug label Dec 8, 2020
trel pushed a commit that referenced this issue Dec 8, 2020
@JustinKyleJames @trel
[#6] Only send x-amz-metadata-directive on CopyObject
7ac4be5 
See:
  https://docs.aws.amazon.com/AmazonS3/latest/API/API_CopyObject.html
  and
  https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPartCopy.html
@trel trel closed this as completed Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JustinKyleJames JustinKyleJames

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trel @JustinKyleJames