Review comments

iron-fish · Sep 6, 2023 · b8bd336 · b8bd336
1 parent b8602db
commit b8bd336
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/ironfish/src/network/blockFetcher.ts b/ironfish/src/network/blockFetcher.ts
@@ -73,7 +73,7 @@ type BlockState =
   | {
       action: 'PROCESSING_FULL_BLOCK'
       block: Block
-      firstSeenBy?: Identity
+      firstSeenBy: Identity | null
     }
 
 export class BlockFetcher {
@@ -231,9 +231,9 @@ export class BlockFetcher {
   /**
    * Return the first peer that notified us of this block
    */
-  firstSeenBy(hash: BlockHash): Identity | undefined {
+  firstSeenBy(hash: BlockHash): Identity | null {
     const currentState = this.pending.get(hash)
-    return currentState?.firstSeenBy
+    return currentState ? currentState.firstSeenBy : null
   }
 
   requestBlockTransactions(
@@ -389,7 +389,7 @@ export class BlockFetcher {
       this.pending.set(hash, {
         action: 'PROCESSING_FULL_BLOCK',
         block,
-        firstSeenBy: currentState?.firstSeenBy ?? peer.state.identity ?? undefined,
+        firstSeenBy: currentState?.firstSeenBy ?? peer.state.identity ?? null,
       })
     }
   }

diff --git a/ironfish/src/telemetry/telemetry.ts b/ironfish/src/telemetry/telemetry.ts
@@ -403,7 +403,7 @@ export class Telemetry {
     })
   }
 
-  submitNewBlockSeen(block: Block, seenAt: Date, peerId?: Identity): void {
+  submitNewBlockSeen(block: Block, seenAt: Date, peerId: Identity | null): void {
     this.submit({
       measurement: 'block_propagation',
       timestamp: seenAt,
@@ -422,7 +422,7 @@ export class Telemetry {
         {
           name: 'firstSeenBy',
           type: 'string',
-          value: peerId || '',
+          value: peerId ?? '',
         },
         {
           name: 'sequence',