Change the Rust depdendencies to use our newly published crates #5590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces all the dependencies on our forked crates on `github.com` to the corresponding crates on `crates.io`. Specifically: * `bellperson` -> `ironfish-bellperson` * `jubjub` -> `ironfish-jubjub` * `zcash_primitives` -> `ironfish-primitives` * `zcash_proofs` -> `ironfish-proofs` The following crates were also being consumed from `github.com` and have been restored to the original version on `crates.io` (no need to publish a fork): * `equihash` * `f4jumble` * `zcash_address` * `zcash_encoding` * `zcash_encoding` * `zcash_note_encryption` With this commit, `ironfish-zkp` and `ironfish-rust` have 100% of their dependencies on crates on `crates.io`.
mat-if
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit replaces all the dependencies on our forked crates on
github.comto the corresponding crates oncrates.io. Specifically:bellperson->ironfish-bellpersonjubjub->ironfish-jubjubzcash_primitives->ironfish-primitiveszcash_proofs->ironfish-proofsThe following crates were also being consumed from
github.comand have been restored to the original version oncrates.io(no need to publish a fork):equihashf4jumblezcash_addresszcash_encodingzcash_encodingzcash_note_encryptionWith this commit,
ironfish-zkpandironfish-rusthave 100% of their dependencies on crates oncrates.io.Testing Plan
cargo publish --dry-run -p ironfish_zkp(can't do the same withironfishbeforeironfish_zkpis published)Cargo.lockand verify that there are no URIs starting withgit+https://; alternatively: runcargo treeand check that there are no URIs starting withhttps://Documentation
N/A
Breaking Change
N/A