Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irssi-feed.pl] don't repost same urls #843

Open
ralyodio opened this issue Apr 30, 2023 · 2 comments
Open

[irssi-feed.pl] don't repost same urls #843

ralyodio opened this issue Apr 30, 2023 · 2 comments

Comments

@ralyodio
Copy link

would be nice if we had a local cache of feed posts so we don't repost the same link all the time if the feed hasn't been changed. Maybe even just take a hash of the feed content and compare it before running again.

@ailin-nemui
Copy link
Contributor

@jcaesar

@jcaesar
Copy link

jcaesar commented Nov 30, 2023

In theory, the script already implements deduplication.

push(@news, $item) if(not exists $itemids->{$item->id});

Loading up my old and unused-for-I-don't-known-how-many years irssi configuration, this still works. (Though it probably doesn't persist over irssi restarts.)

I think there's two possibilities

  • The feed ralyodio is using doesn't have (stable) post ids
  • The id extraction broke somehow because of a dependency update

@ralyodio Can you provide a link to a feed that doesn't work, and maybe check with http://blog.fefe.de/rss.xml whether that does work?

(In general, I don't think I can promise I'll fix this. I don't use irssi regularly anymore, and irssi-feed.pl is probably not a good idea in 2023, with its lack of https, and random short freezes. I suspect there's better bots for rss feeds these days.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants