-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA reports for science-mode L0B files? #11
Comments
A few thoughts-- In order to generate backscatter/phase histograms, the hypothetical L0B QA module would want to call the following nisarqa functions: In general, L0B products may have non-uniform PRIs so generating azimuth spectra is nontrivial. If we want to be able to compute azimuth spectra for L0B products with fixed PRI, however, the module should additionally call
In order to compute azimuth spectra for products with fixed PRI, it would additionally need to implement So, in theory, it should be sufficient to implement an Integrating this
So we'd have to re-conceptualize the product reader class hierarchy a bit to distinguish L1/L2 products that contain metadata LUTs from L0 products that don't. Otherwise, AFAICT there doesn't seem to be any reason that If I had to estimate the scope of work, I'd guess that it's probably not less than 3-4 weeks of effort to implement an Footnotes
|
Thank you for this assessment, @gmgunter ! Couple of thoughts:
|
Thanks @gmgunter and @nemo794 for your quick and thorough thoughts.
Thank you so much guys! |
Thanks @gmgunter @nemo794 and @rad-eng-59 for the detailed discussion. Clearly, the L0B QA will require reorganization of the product readers in nisarqa which is currently out of scope for us. If the scope of our work for nisarqa will change, we will revisit this topic. |
@rad-eng-59 relayed a request for adding some level of QA support for NISAR L0Bs (specifically science-mode L0Bs -- not DM1 or DM2 products that have significantly different data layouts).
@gmgunter will investigate the feasibility of integrating a product reader for science-mode L0B products into the nisarqa product reader class hierarchy. The reader only needs to access the minimal subset of product contents necessary to generate plots such as spectra, histograms, etc.
A possible alternative to adding a QA module for L0B products would be to add nisarqa as a dependency of the existing L0B QA tool so that that software can use the existing functions to plot spectra, histograms, etc (assuming that these functions are sufficiently modular/reusable).
cc @hfattahi @nemo794
The text was updated successfully, but these errors were encountered: