You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
iftype(attribute) in [bytearray, bytes, np.bytes_]:
attributes[key] =attribute.decode("utf-8")
else:
attributes[key] =attribute
This allows Attributes with variable-length string dtypes to pass through, and go un-logged. By NISAR conventions, all strings should be saved as as fixed-length bytes strings (or lists of fixed-length byte strings).
So, we need to add a check that string Attributes are either correctly fixed-length byte strings (or lists of fixed-length byte strings), or that an error is logged.
The text was updated successfully, but these errors were encountered:
Currently, the QA XML checker reads in each Dataset's Attribute keys and values, only performing lightweight conversions if needed:
nisarqa/src/nisarqa/utils/file_verification/h5_parser.py
Lines 41 to 47 in 1fd188c
This allows Attributes with variable-length string dtypes to pass through, and go un-logged. By NISAR conventions, all strings should be saved as as fixed-length bytes strings (or lists of fixed-length byte strings).
So, we need to add a check that string Attributes are either correctly fixed-length byte strings (or lists of fixed-length byte strings), or that an error is logged.
The text was updated successfully, but these errors were encountered: