Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precedence of code owners #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmgunter
Copy link
Member

@gmgunter gmgunter commented Dec 9, 2024

Later lines in a CODEOWNERS file take precedence over earlier lines. Previously, we put the two code owners on separate lines with identical wildcard patterns. This caused only the second code owner to be requested for review. This update puts both code owners on the same line, indicating co-ownership.

Later lines in a CODEOWNERS file take precedence over earlier lines.
Previously, we put the two code owners on separate lines with identical
wildcard patterns. This caused only the second code owner to be
requested for review. This update puts both code owners on the same
line, indicating co-ownership.
@gmgunter gmgunter requested a review from nemo794 December 9, 2024 20:28
Copy link
Collaborator

@nemo794 nemo794 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, great fix. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants