You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been playing around with changing the defaults and acceptable parameters of load_bursts. I wanted to check if others found this useful or not before I decided to open a PR or scrap it.
The default is to load all subswaths instead of requiring the user to pass one. When you ask for multiple, you get a list of lists.
add the ability to just pass the directory holding orbits instead of needing to get the full orbit path in advance (this just takes the example call of get_orbit_file_from_dir and moves it into load_bursts)
relatedly, auto_download=True seems like a nice default to me
I believe this wouldn't break anyone's calls to how their currently using load_bursts, but would just expand what you're allowed to pass in.
If this seems useful to orders, i'll make a PR; otherwise I can close this
The text was updated successfully, but these errors were encountered:
Checked for duplicates
Yes - I've already checked
Alternatives considered
Yes - and alternatives don't suffice
Related problems
I've been playing around with changing the defaults and acceptable parameters of
load_bursts
. I wanted to check if others found this useful or not before I decided to open a PR or scrap it.https://github.com/opera-adt/s1-reader/compare/main...scottstanie:load-burst-defaults?expand=1
Describe the feature request
I wanted to be able to get all the burst metadata with as few lines as possible. Right now that looks like
The differences are
get_orbit_file_from_dir
and moves it intoload_bursts
)auto_download=True
seems like a nice default to meI believe this wouldn't break anyone's calls to how their currently using
load_bursts
, but would just expand what you're allowed to pass in.If this seems useful to orders, i'll make a PR; otherwise I can close this
The text was updated successfully, but these errors were encountered: