Unit test fixes #58
Merged
Unit test fixes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiangJYu
requested review from
hfattahi,
scottstanie,
yunjunz,
seongsujeong,
gshiroma and
vbrancat
seongsujeong
added a commit
to seongsujeong/s1-reader
that referenced
this pull request
Aug 2, 2022
Unit test fixes from isce-framework#58
seongsujeong
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Tested the updates by merging this into the branch in PR #48. CircleCI passed with no error.
Thank you for the updates on the unit test. Nice work!
scottstanie
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes include: