Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for removeLayer #57

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

matthewberryman
Copy link

Isolates the fix in #46 for removeLayer() - per comments in that pull request, the fix in #50 wasn't complete and we were still seeing the removeLayer error #49 .
Have tested this and it solves the issue (thanks @ForgottenLords )

@karlitos
Copy link

Can you please merge this fix into whatever branch, so I can get it with NPM ? I just spend several hours pulling my hair out till I found the source of the bug and got finally to this PR 😭

@TravnikovDev
Copy link

OMG merge this please !

@vinayakkulkarni
Copy link

Merge this please. very basic feature that should've been present from the beginning.

@ka7eh
Copy link

ka7eh commented Apr 16, 2018

Any update on merging this changeset?

@TravnikovDev
Copy link

@ka7eh This package is dead because layers control now included in leaflet
http://leafletjs.com/reference-1.3.0.html#control-layers

@ka7eh
Copy link

ka7eh commented Apr 17, 2018

@TPABHuKOB thanks for the update.

@karlitos
Copy link

@TPABHuKOB I do not think Leaflets layer controll is a full replacement of the groupedlayercontrol. How do you do grouping - headings ? You can pass HTML in the Layers labels, but the controls - checkboxes, radios - are placed before the labels. Please see my example.

@zacharyburnett
Copy link

I can confirm from my local installation that this pull request fixes the problem with removeLayer. It is a single-line fix, and definitely should be merged into master.

@corrigancd
Copy link

Also confirmed, nice fix.

@Azbesciak
Copy link

Owner? I'm just another person who has faced this problem and solved it myself ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants