-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for removeLayer #57
base: gh-pages
Are you sure you want to change the base?
Conversation
Can you please merge this fix into whatever branch, so I can get it with NPM ? I just spend several hours pulling my hair out till I found the source of the bug and got finally to this PR 😭 |
OMG merge this please ! |
Merge this please. very basic feature that should've been present from the beginning. |
Any update on merging this changeset? |
@ka7eh This package is dead because layers control now included in leaflet |
@TPABHuKOB thanks for the update. |
@TPABHuKOB I do not think Leaflets layer controll is a full replacement of the groupedlayercontrol. How do you do grouping - headings ? You can pass HTML in the Layers labels, but the controls - checkboxes, radios - are placed before the labels. Please see my example. |
I can confirm from my local installation that this pull request fixes the problem with |
Also confirmed, nice fix. |
Owner? I'm just another person who has faced this problem and solved it myself ... |
Isolates the fix in #46 for removeLayer() - per comments in that pull request, the fix in #50 wasn't complete and we were still seeing the removeLayer error #49 .
Have tested this and it solves the issue (thanks @ForgottenLords )