Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put 3rd level navigation in <ul> instead of <div> #258

Open
Tracked by #265
rc-davis opened this issue Apr 5, 2022 · 0 comments
Open
Tracked by #265

Put 3rd level navigation in <ul> instead of <div> #258

rc-davis opened this issue Apr 5, 2022 · 0 comments

Comments

@rc-davis
Copy link

rc-davis commented Apr 5, 2022

Google Lighthouse complains when Isomer navigation menus contain 3rd level navigation, because the 3rd level is contained in a <div> tag. This was highlighted for the NCCS site.

li

The problem can be see on this test page. The navigation bar contains structures like the following:

<ul class="bp-menu-list">
    <li class="third-level-nav-header">
        <a aria-label="Page" class="third-level-nav-header is-active">Page
            <i aria-hidden="true" class="sgds-icon sgds-icon-chevron-up is-pulled-right is-size-4"/></a>
    </li>
    <div class="third-level-nav-div ">
        <li>
            <a class="third-level-nav-item padding--top--none has-text-secondary has-text-weight-bold" href="/collection/page/subpage">Subpage</a>
        </li>
    </div>
</ul>

We should fix this by putting 3rd level navigation inside another <ul> tag instead of a <div> tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant