Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluations & statistics #2536

Open
katgirl opened this issue Sep 7, 2024 · 9 comments
Open

Evaluations & statistics #2536

katgirl opened this issue Sep 7, 2024 · 9 comments

Comments

@katgirl
Copy link
Contributor

katgirl commented Sep 7, 2024

Isotope Version 2.9.0

For sales statistics
image

but at Sales summary
image

The number of products is the number of units.
The sum of sales and the resulting average is also incorrect

@katgirl
Copy link
Contributor Author

katgirl commented Sep 7, 2024

The Problem is:

https://github.com/isotope/core/blob/2.9/system/modules/isotope_reports/library/Isotope/BackendModule/Reports.php#L150C24-L165C44

The LEFT JOIN at tl_iso_product_collection_item generate duplicate content by order.

katgirl added a commit to katgirl/isotope that referenced this issue Sep 7, 2024
katgirl added a commit to katgirl/isotope that referenced this issue Sep 7, 2024
@aschempp
Copy link
Member

@error08 could you help with this and tell if #2537 is the correct fix for your new statistics?

@error08
Copy link
Contributor

error08 commented Oct 10, 2024

Hi @aschempp and @katgirl, if I understand it right, I would it solve this way: #2542. @katgirl: Your fix, sums the quantity of the items, but here we want display the products, right?

@error08
Copy link
Contributor

error08 commented Oct 10, 2024

@katgirl The sales total here are the tax free value of the all paid orders in the time range minus the discounts. I will double check that next week.

@aschempp
Copy link
Member

but here we want display the products, right?

If I understand correctly, we're not sure we want to show the number of "different products", or the number of quantities? Personally (I'm not a shop owner!) I would expect the number of items here, the number of things I will pack into my shipping boxes.

@katgirl did your statement about incorrect resulting average include net or gross prices?

@aschempp
Copy link
Member

Maybe we should name the columns "Net Sales Total" and "Net Sales ø" if that would make it more obvious?

@aschempp
Copy link
Member

Any opinions on the matter?

@error08
Copy link
Contributor

error08 commented Nov 2, 2024

I'm fine with "Net Sales Total" and "Net Sales ø". Regarding the issue, I will try to test it this weekend.

@error08
Copy link
Contributor

error08 commented Nov 2, 2024

@aschempp , @katgirl : I have found the bug, please double check the PR 2542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants