Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve follow/follow_all #41

Merged
merged 15 commits into from
Oct 23, 2024
Merged

Improve follow/follow_all #41

merged 15 commits into from
Oct 23, 2024

Conversation

MatthewZMSU
Copy link
Contributor

Description

In this PR I have improved follow method of PuppeteerResponse class.
Also I have added follow_all method in it.
Updated documentation.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Tested it with several local spiders.
They worked fine.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@MatthewZMSU MatthewZMSU self-assigned this Sep 12, 2024
@MatthewZMSU MatthewZMSU added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 12, 2024
mxsnq
mxsnq reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@mxsnq mxsnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged composite actions, please merge master and take them into account in follow methods.

scrapypuppeteer/response.py Outdated Show resolved Hide resolved
scrapypuppeteer/response.py Outdated Show resolved Hide resolved
@mxsnq mxsnq merged commit f41d5fa into master Oct 23, 2024
16 checks passed
@mxsnq mxsnq deleted the follow-all-html-response branch October 23, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxsnq mxsnq mxsnq approved these changes

Assignees

@MatthewZMSU MatthewZMSU

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewZMSU @mxsnq