Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should RepeatingFormAccessor.insert be (in)tolerant to empty lists? #42

Open
faassen opened this issue Nov 7, 2018 · 1 comment
Open

should RepeatingFormAccessor.insert be (in)tolerant to empty lists? #42

faassen opened this issue Nov 7, 2018 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@faassen
Copy link
Contributor

faassen commented Nov 7, 2018

If we create a new item with insert() and the list is currently empty, should we accept arbitrary indices and just ignore it, transforming it into a push()?
@faassen
Copy link
Contributor Author

faassen commented Nov 7, 2018

Or perhaps instead we want to crash hard in such cases with a clear error, so that the user is warned their reasoning is wrong.

@faassen faassen changed the title should RepeatingFormAccessor.insert be tolerant to empty lists? should RepeatingFormAccessor.insert be (in)tolerant to empty lists? Nov 9, 2018
@faassen faassen added enhancement New feature or request good first issue Good for newcomers labels Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@faassen