Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source repository URL is not set in commit messages #6

Open
mmurooka opened this issue Nov 17, 2021 · 0 comments
Open

Source repository URL is not set in commit messages #6

mmurooka opened this issue Nov 17, 2021 · 0 comments

Comments

@mmurooka
Copy link
Member

As you can see in the following commit message of robot description packages, the source repository URL is invalid.

https://gite.lirmm.fr/mc-hrp2/hrp2_drc_description/-/commit/1b72d03dde4dac7db25176e96b520c346033e29e

Generated from 59de8e9
Source repository: https://github.com/group/project
Source commit: https://github.com/group/project/commit/59de8e96679dc7bec05581a68ca2b7ffe811a4ef
...

This is because first repo_uri is set with default robot_repository

export repo_uri="https://github.com/$robot_repository"

and then robot_repository is set by loading a robot-specific generate_config.sh
. $robot_dir/generate_config.sh

https://github.com/isri-aist/hrp2kai/blob/59de8e96679dc7bec05581a68ca2b7ffe811a4ef/generate_config.sh#L8

What is the clean solution for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant