Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Upgrade tonic to hyper 1.0 support #796

Closed
howardjohn opened this issue Feb 2, 2024 · 3 comments
Closed

Tracking issue: Upgrade tonic to hyper 1.0 support #796

howardjohn opened this issue Feb 2, 2024 · 3 comments
Labels
Ambient Beta Must have for OSS Beta of Ambient Mesh

Comments

@howardjohn
Copy link
Member

Tracking issue to get off forks.

We currently need a compat shim, which we have a fork of: davidpdrsn/tower-hyper-http-body-compat#7. Worst case, we should get that merged so we are off forks.

best case, tonic adopts 1.0 so we do not need a shim at all: hyperium/tonic#1307

@howardjohn howardjohn added the Ambient Beta Must have for OSS Beta of Ambient Mesh label Feb 2, 2024
@daixiang0
Copy link
Member

Is fixed by #726?

@howardjohn
Copy link
Member Author

No, we have a shim for tonic because its missing 1.0 support. Blocked on hyperium/tonic#1307

@howardjohn
Copy link
Member Author

this is done

$ cargo tree | rg hyper
├── hyper v1.4.1
├── hyper-rustls v0.27.2
│   ├── hyper v1.4.1 (*)
│   ├── hyper-util v0.1.7
│   │   ├── hyper v1.4.1 (*)
├── hyper-util v0.1.7 (*)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ambient Beta Must have for OSS Beta of Ambient Mesh
Projects
None yet
Development

No branches or pull requests

2 participants