Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Parallelization of npm jobs #358

Open
2 tasks done
devtobi opened this issue Sep 19, 2024 · 3 comments
Open
2 tasks done

[Maintenance] Parallelization of npm jobs #358

devtobi opened this issue Sep 19, 2024 · 3 comments
Labels
Priority: Low The issue contains work with low priority. Template: Frontend Issues regarding the frontend template. Template: Webcomponent Issues regarding the webcomponent template. Type: Maintenance The issue contains maintenance work.

Comments

@devtobi
Copy link
Member

devtobi commented Sep 19, 2024

Relevant template

refarch-frontend, refarch-webcomponent

Problem description (optional)

Currently for our custom npm jobs defined in package.json we sequentially execute the steps (like prettier, ESLint, vue-tsc etc.).
This also means that follow up jobs fail if the previous one failed.
This hides important information about the result of a job (e.g. prettier fails and we don't know if ESLint would as well or not)

Desired solution

By using parallel execution of steps (e.g. with a package like https://github.com/open-cli-tools/concurrently) we can execute e.g. the linting steps in parallel and transparently show which part of the tooling failed.
The tool waits until all defined jobs where run and then aggregates into a final status code.
This way we give more transparency to the developer and increase the execution speed of linting (and potentially other stuff) on local machines and in CI/CD.

Considered alternatives (optional)

No response

Additional context (optional)

No response

No duplicate

  • I confirm that this issue is not a duplicate

Code of Conduct

  • I agree to follow this project's Code of Conduct
@devtobi devtobi added Type: Maintenance The issue contains maintenance work. Priority: Medium The issue contains work with medium priority. labels Sep 19, 2024
@devtobi devtobi added Template: Webcomponent Issues regarding the webcomponent template. Template: Frontend Issues regarding the frontend template. labels Sep 20, 2024
@devtobi
Copy link
Member Author

devtobi commented Oct 31, 2024

There was a discussion related to splitting the different linting tools into separate npm scripts so they can be executed in parallel but in separate steps inside GitHub Actions.
We could combine both solutions and provide a parallelized script for local development running all lint-tools at once as well as providing individual scripts for GitHub Actions execution.

@devtobi devtobi added Priority: Low The issue contains work with low priority. and removed Priority: Medium The issue contains work with medium priority. labels Nov 7, 2024
@devtobi
Copy link
Member Author

devtobi commented Nov 7, 2024

Discussed as not planned, because speed is not a issue here.

@devtobi
Copy link
Member Author

devtobi commented Nov 20, 2024

I tested this on a larger project and the speed improvements where significant. That's why should look further into this.

@devtobi devtobi moved this from Open to Accepted in it@M RefArch Templates Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low The issue contains work with low priority. Template: Frontend Issues regarding the frontend template. Template: Webcomponent Issues regarding the webcomponent template. Type: Maintenance The issue contains maintenance work.
Projects
Status: Accepted
Development

No branches or pull requests

1 participant