Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsed 550 objects for beatmap 'Queen's Blade Spiral Chaos (Yousei Teikoku) - Gekkakou [Collab]', 551 objects expected. #420

Closed
Haringat opened this issue Aug 12, 2018 · 5 comments · Fixed by #422
Labels

Comments

@Haringat
Copy link
Contributor

Version: 0.16.1
Build date: 2018-08-08 00:33
OS: Linux (amd64)
JRE: 10.0.2
OpenGL version: 4.6.0 NVIDIA 396.45 (NVIDIA Corporation)
Error: Parsed 550 objects for beatmap 'Queen's Blade Spiral Chaos (Yousei Teikoku) - Gekkakou [Collab]', 551 objects expected.

@tpenguinltg
Copy link
Contributor

We don't officially support Java 10, but that's probably not the issue here.

Was there a stack trace?

@Haringat
Copy link
Contributor Author

I didn't see one. However, I hadn't started opsu via console and since it crashed right after showing the error dialog I can't be sure.
When I come home I will check if there is a stacktrace as well as whether or not this occurs in Java 8 and 9.

@tpenguinltg
Copy link
Contributor

If there was an error, it should be logged to .opsu.log file in your config directory, which is wherever the JAR file is if you got it from the GitHub releases, or ~/.config/opsu/ if you built with -DXDG=true (which is the case if you got it from the AUR).

Note that we also don't officially support Java 9, though it'll probably also still work.

@Haringat
Copy link
Contributor Author

Due to #421 I can't test it with jdk8.
However, I tested it with jdk 9 and 10 with the same result. Here is the log:

Tue Aug 14 19:16:03 CEST 2018 WARN:Failed to read hit object '299,84,27995,2,0,B|256:69|256:69|216:84,1,90,8|208' for beatmap 'Queen's Blade Spiral Chaos (Yousei Teikoku) - Gekkakou [Collab]'.
java.lang.NumberFormatException: Value out of range. Value:"208" Radix:10
	at java.base/java.lang.Byte.parseByte(Byte.java:154)
	at java.base/java.lang.Byte.parseByte(Byte.java:178)
	at itdelatrisu.opsu.beatmap.HitObject.<init>(HitObject.java:236)
	at itdelatrisu.opsu.beatmap.BeatmapParser.parseHitObjects(BeatmapParser.java:718)
	at itdelatrisu.opsu.beatmap.BeatmapDifficultyCalculator.<init>(BeatmapDifficultyCalculator.java:86)
	at itdelatrisu.opsu.states.SongMenu.calculateStarRatings(SongMenu.java:1972)
	at itdelatrisu.opsu.states.SongMenu.setFocus(SongMenu.java:1752)
	at itdelatrisu.opsu.states.SongMenu.mouseClicked(SongMenu.java:1135)
	at org.newdawn.slick.state.StateBasedGame.mouseClicked(StateBasedGame.java:488)
	at org.newdawn.slick.Input.fireMouseClicked(Input.java:1555)
	at org.newdawn.slick.Input.considerDoubleClick(Input.java:1125)
	at org.newdawn.slick.Input.poll(Input.java:1257)
	at org.newdawn.slick.GameContainer.updateAndRender(GameContainer.java:680)
	at itdelatrisu.opsu.Container.gameLoop(Container.java:136)
	at itdelatrisu.opsu.Container.start(Container.java:80)
	at itdelatrisu.opsu.Opsu.main(Opsu.java:203)
Tue Aug 14 19:16:03 CEST 2018 ERROR:Parsed 550 objects for beatmap 'Queen's Blade Spiral Chaos (Yousei Teikoku) - Gekkakou [Collab]', 551 objects expected.
Tue Aug 14 19:16:05 CEST 2018 ERROR:null
java.lang.NullPointerException
	at itdelatrisu.opsu.beatmap.BeatmapDifficultyCalculator.calculate(BeatmapDifficultyCalculator.java:134)
	at itdelatrisu.opsu.states.SongMenu.calculateStarRatings(SongMenu.java:1973)
	at itdelatrisu.opsu.states.SongMenu.setFocus(SongMenu.java:1752)
	at itdelatrisu.opsu.states.SongMenu.mouseClicked(SongMenu.java:1135)
	at org.newdawn.slick.state.StateBasedGame.mouseClicked(StateBasedGame.java:488)
	at org.newdawn.slick.Input.fireMouseClicked(Input.java:1555)
	at org.newdawn.slick.Input.considerDoubleClick(Input.java:1125)
	at org.newdawn.slick.Input.poll(Input.java:1257)
	at org.newdawn.slick.GameContainer.updateAndRender(GameContainer.java:680)
	at itdelatrisu.opsu.Container.gameLoop(Container.java:136)
	at itdelatrisu.opsu.Container.start(Container.java:80)
	at itdelatrisu.opsu.Opsu.main(Opsu.java:203)

@Haringat
Copy link
Contributor Author

Looks like Osu! used an unsigned byte for that value while Opsu! uses Java's byte (which is signed). Thus values >= 128 cause an error. I fixed it and will submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants