Cleanup parameter naming, duplicated parameters, formatting (CTERA-137).

iterate-ch · Jan 11, 2024 · 4e7b873 · 4e7b873
1 parent 2a44621
commit 4e7b873
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 13 deletions.
diff --git a/ctera/src/main/java/ch/cyberduck/core/ctera/CteraCopyFeature.java b/ctera/src/main/java/ch/cyberduck/core/ctera/CteraCopyFeature.java
@@ -23,8 +23,8 @@
 
 class CteraCopyFeature extends DAVCopyFeature {
 
-    public CteraCopyFeature(final CteraSession cteraSession, final CteraSession session) {
-        super(cteraSession);
+    public CteraCopyFeature(final CteraSession session) {
+        super(session);
     }
 
     @Override

diff --git a/ctera/src/main/java/ch/cyberduck/core/ctera/CteraDeleteFeature.java b/ctera/src/main/java/ch/cyberduck/core/ctera/CteraDeleteFeature.java
@@ -24,8 +24,8 @@
 
 class CteraDeleteFeature extends DAVDeleteFeature {
 
-    public CteraDeleteFeature(final CteraSession cteraSession, final CteraSession session) {
-        super(cteraSession);
+    public CteraDeleteFeature(final CteraSession session) {
+        super(session);
     }
 
     @Override

diff --git a/ctera/src/main/java/ch/cyberduck/core/ctera/CteraListService.java b/ctera/src/main/java/ch/cyberduck/core/ctera/CteraListService.java
@@ -33,9 +33,9 @@
 class CteraListService extends DAVListService {
     private final CteraSession cteraSession;
 
-    public CteraListService(final CteraSession cteraSession) {
-        super(cteraSession, new CteraAttributesFinderFeature(cteraSession));
-        this.cteraSession = cteraSession;
+    public CteraListService(final CteraSession session) {
+        super(session, new CteraAttributesFinderFeature(session));
+        this.cteraSession = session;
     }
 //        @Override
 //        public void preflight(Path file) throws BackgroundException {

diff --git a/ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java b/ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java
@@ -227,13 +227,13 @@ public <T> T _getFeature(final Class<T> type) {
             return (T) new CteraReadFeature(this, session);
         }
         if(type == Write.class) {
-            return (T) new CteraWriteFeature(this, session);
+            return (T) new CteraWriteFeature(this);
         }
         if(type == Delete.class) {
-            return (T) new CteraDeleteFeature(this, session);
+            return (T) new CteraDeleteFeature(session);
         }
         if(type == Copy.class) {
-            return (T) new CteraCopyFeature(this, session);
+            return (T) new CteraCopyFeature(session);
         }
         return super._getFeature(type);
     }

diff --git a/ctera/src/main/java/ch/cyberduck/core/ctera/CteraWriteFeature.java b/ctera/src/main/java/ch/cyberduck/core/ctera/CteraWriteFeature.java
@@ -24,8 +24,8 @@
 
 class CteraWriteFeature extends DAVWriteFeature {
 
-    public CteraWriteFeature(final CteraSession cteraSession, final CteraSession session) {
-        super(cteraSession);
+    public CteraWriteFeature(final CteraSession session) {
+        super(session);
     }
 
     @Override

diff --git a/ctera/src/test/java/ch/cyberduck/core/ctera/CteraPermissionFeatureAclToPermissionTest.java b/ctera/src/test/java/ch/cyberduck/core/ctera/CteraPermissionFeatureAclToPermissionTest.java
@@ -1,4 +1,6 @@
-package ch.cyberduck.core.ctera;/*
+package ch.cyberduck.core.ctera;
+
+/*
  * Copyright (c) 2002-2023 iterate GmbH. All rights reserved.
  * https://cyberduck.io/
  *