Update default templates #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Sep 11, 2023
| { | ||
| "transform": [ | ||
| { | ||
| "calculate": "datum.rev + '::' + datum.filename + '::' + datum.field", # noqa: E501 |
There was a problem hiding this comment.
These fields have to be present in the data in order to implement the new tooltips. I am not sure if these or dvc_data_version_info are present in the Studio/DVC data. Will need to investigate.
There was a problem hiding this comment.
This line is also too long and giving pylint the shits.
There was a problem hiding this comment.
From iterative/dvc#9931 (comment) seems like we want to add an actual ID field instead of calculating this.
2 tasks
|
Changing approach as per iterative/dvc#9940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds zoom and pan functionality to the
bar_horizontal,bar_horizontal_sorted,smooth,linearandsimpletemplates. It also updates thesmooth/linearplot's tooltips.