Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: standardise across DVC/Studio/VS Code #4978

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Nov 7, 2023

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏


Part of iterative/dvc#9940.

Docs change for iterative/dvc#9931.

@shcheklein shcheklein temporarily deployed to dvc-org-update-anchors--kc3hbk November 7, 2023 03:09 Inactive
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Link Check Report

There were no links to check!

@mattseddon mattseddon changed the title plots: standardise/consolidate plots data across products plots: standardise across DVC/Studio/VS Code Nov 7, 2023
@mattseddon mattseddon self-assigned this Nov 7, 2023
@dberenbaum dberenbaum added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Nov 9, 2023
@shcheklein shcheklein temporarily deployed to dvc-org-update-anchors--kc3hbk November 14, 2023 02:43 Inactive
@mattseddon mattseddon marked this pull request as ready for review November 27, 2023 01:59
@shcheklein shcheklein temporarily deployed to dvc-org-update-anchors--kc3hbk November 27, 2023 02:00 Inactive
@mattseddon
Copy link
Member Author

The build is failing due to the lint issue fixed by #5004.

@shcheklein shcheklein temporarily deployed to dvc-org-update-anchors--kc3hbk November 27, 2023 02:15 Inactive
@mattseddon mattseddon requested review from a team and removed request for dberenbaum November 27, 2023 03:26
@shcheklein shcheklein temporarily deployed to dvc-org-update-anchors--kc3hbk December 1, 2023 04:52 Inactive
@mattseddon mattseddon removed the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Dec 6, 2023
@shcheklein shcheklein temporarily deployed to dvc-org-update-anchors--kc3hbk December 6, 2023 01:16 Inactive
Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this one @mattseddon. LGTM although we should consider moving this info out of the CLI ref and focusing less on the dvc plots commands here.

@dberenbaum dberenbaum mentioned this pull request Dec 6, 2023
@dberenbaum dberenbaum merged commit ea70589 into main Dec 6, 2023
5 checks passed
@dberenbaum dberenbaum deleted the update-anchors-docs branch December 6, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants