Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace index and state with one (workspace? fs?) index #6916

Closed
efiop opened this issue Nov 2, 2021 · 1 comment
Closed

replace index and state with one (workspace? fs?) index #6916

efiop opened this issue Nov 2, 2021 · 1 comment
Labels
enhancement Enhances DVC feature request Requesting a new feature refactoring Factoring and re-factoring

Comments

@efiop
Copy link
Contributor

efiop commented Nov 2, 2021

Both our state and index db, do the same thing: they store information about files that exist on a particular filesystem along with some metadata. They currently use different formats, but they could be unified into one general
filesystem index. This is kinda similar to git's index, but is much more generalized for arbitrary filesystems/clouds.

Having one fs index, will also allow us to generalize our state for any possible filesystem, which will speedup external dependecies/outputs and import-url operations, since we won't have to rehash files every time.

Fsspec filesystems use dircache that does something similar, but is not persistent. Might be worth inheriting from it, but making it persistent for us.

Ideally the format of the storage should be language agnostic. Sqlite db with fspath as a key and metadata as a value (e.g. in string or binary form, to avoid complicated table structures).

@efiop efiop added enhancement Enhances DVC refactoring Factoring and re-factoring feature request Requesting a new feature labels Nov 2, 2021
@skshetry
Copy link
Member

state and index were replaced with one single index from sqltrie. We haven't completed the migration yet, but this issue can be closed.

The progress of dvc-data index migration can be tracked in #9333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC feature request Requesting a new feature refactoring Factoring and re-factoring
Projects
None yet
Development

No branches or pull requests

2 participants