Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove specific dependency in field_divB0 #21

Open
krystophny opened this issue Nov 27, 2023 · 2 comments
Open

Remove specific dependency in field_divB0 #21

krystophny opened this issue Nov 27, 2023 · 2 comments

Comments

@krystophny
Copy link
Member

krystophny commented Nov 27, 2023 •
edited
Loading

GORILLA/SRC/field_divB0.f90

Line 67 in 4cfe407

use tetra_grid_settings_mod, only: g_file_filename, convex_wall_filename, iaxieq_in !=> Michael Eder, 05 May 2022

This makes it hard to decouple code and leads to "yet another variant of field_divB0.f90". Check also similar things elsewhere.
@krystophny krystophny changed the title Remove specific dependency here Remove specific dependency in field_divB0 Nov 27, 2023
@krystophny
Copy link
Member Author

possible solution: add namelist section specifically for field_divB0 members and move the variables into a module inside field_divB0.f90.

@krystophny
Copy link
Member Author

Oh no it gets worse. Any workaround I tried to at least set the variables is prohibited by the well-meant protected flag.

GORILLA/SRC/tetra_grid_settings_mod.f90

Line 27 in 2d54b35

character*64,public,protected :: g_file_filename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krystophny