-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting to Swift #39
Comments
Hi, I don't think anyone did that - so please feel free to port it to swift. I can help with that too if you need another hand! |
Sweet I’ll send you the PR. Also going to see if I can work in autolayout. Or at the very least refactor out that ‘resetSubviews’ method. Seems like most of it could be moved to ‘init’ and ‘layoutSubviews’ |
Yes I agree that autolayout would be great and should be used instead of my current messy screen size calculation. But are you putting the swift code in this same repo? I think a separate repo would be neater. |
Yeah that's why I was saying it probably wouldn't be good to fork it even. I guess it would be a new repo and I would just link back to this repo in the Readme for reference? |
Yes that works - let me know if you need any help. |
I don't think github has a "discussion" secion, so I'm putting this here...
The Objective-C-ness of this is driving me crazy. And to a lesser extent, the non-autolayout-ness. I'm rewriting to Swift in a...new project I guess? I guess it doesn't make sense to fork it since it will be all new code? Has anyone already done this, or is there any reason I shouldn't?
The text was updated successfully, but these errors were encountered: