Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Healthchecks #24

Open
JerboaGobi opened this issue Dec 18, 2024 · 3 comments · May be fixed by #48
Open

[Enhancement] Healthchecks #24

JerboaGobi opened this issue Dec 18, 2024 · 3 comments · May be fixed by #48
Labels
enhancement New feature or request

Comments

@JerboaGobi
Copy link

I think there is a good use case for a /healthcheck endpoint to be added to the application. It would also idea to add a binary that can be used to verify the containers health during runtime or to extend the application so that it has a paramater that acts as the healthcheck. Lastly, to update the Dockerfile so that the healthcheck is performed.
@Fijxu
Copy link
Contributor

Fijxu commented Dec 18, 2024 •
edited
Loading

Of what type of healthcheck are you referring to? To a healthcheck that tells whenever invidious-companion is blocked from Youtube? Or if it replies to the client (a simple http request to a /health endpoint that returns 200)?

@JerboaGobi
Copy link
Author

JerboaGobi commented Dec 18, 2024 via email •
edited by unixfox
Loading

@unixfox unixfox added the enhancement New feature or request label Dec 18, 2024
@Fijxu Fijxu mentioned this issue Dec 18, 2024
Merged
@JerboaGobi
Copy link
Author

Just wanted to say thanks for the work on this request I see PR #27 has been merged into master.

I agree with @unixfox having the healthcheck command builtin is preferred over adding another binary.

I have a better idea. Have the "healthcheck" command builtin into the invidious companion binary.

Add a new helper in the helper folder and if you run "./invidious companion healthcheck" then this will ping /health and confirm if it works or not.

This way, no additional binary!

@Fijxu Fijxu linked a pull request Jan 31, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Image healthcheck. Fijxu/invidious-companion
3 participants
@unixfox @Fijxu @JerboaGobi