Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the request schedule block #65

Open
Zarquan opened this issue Oct 10, 2024 · 2 comments
Open

Refactor the request schedule block #65

Zarquan opened this issue Oct 10, 2024 · 2 comments

Comments

@Zarquan
Copy link
Member

Zarquan commented Oct 10, 2024

Current data model for a schedule block has preparing, executing and finishing in the request.
User wants to specify a single duration, an array of start times for executing, and then leave the rest to the service to make offers.

@Zarquan
Copy link
Member Author

Zarquan commented Oct 12, 2024

OpenAPI request model has been updated to skip preparing and finishing, and include a list for executing.

name: Test request
executable:
  name: Test executable
  type: urn:jupyter-notebook-0.1
  notebook: https://raw.githubusercontent.com/Zarquan/binder-demo/main/02_dmhh.ipynb
schedule:
  requested:
      start:
      - 2024-10-12T02:34:51+00:00/PT0S
      - 2024-10-12T02:34:51+00:00/PT0H
      - 2024-10-12T02:34:51+00:00/PT1H
      - 2024-10-13T02:34:51+00:00/PT1H
      - 2024-10-14T02:34:51+00:00/PT1H
      duration: PT1H

@Zarquan
Copy link
Member Author

Zarquan commented Oct 12, 2024

Current parser requires something in the range part of the start interval.
https://stackoverflow.com/questions/29823129/what-is-the-canonical-representation-of-zero-in-iso-8601-durations

For a date/time with no duration, we still have to include something in the duration part:

- 2024-10-12T02:34:51+00:00/PT0S

So none of these are valid:

- 2024-10-12T02:34:51+00:00
- 2024-10-12T02:34:51+00:00/
- 2024-10-12T02:34:51+00:00/P
- 2024-10-12T02:34:51+00:00/P0
- 2024-10-12T02:34:51+00:00/PT
- 2024-10-12T02:34:51+00:00/PT0

Do we allow a 'bare' date/time without a range, and fill in the /PT0S part ourselves?
So this:

- 2024-10-12T02:34:51+00:00

is expanded to:

- 2024-10-12T02:34:51+00:00/PT0S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant