Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for single Preference and Change default config #16

Open
wants to merge 2 commits into
base: 2.2.3+
Choose a base branch
from

Conversation

robin-homberg
Copy link

Please review.

  • Fixes one of multiple preferences mentioned in Breaking global preferences #15 . Change like this still needs to be done for other preferences.
  • Changes default config to inactive and hide overlayscript, so just by installing the module it's not yet shown on the page. This is important for magento2 installations with multiple websites, where the module should not be shown on all of them

@robin-homberg robin-homberg changed the title Feature/fix preferences Fix for single Preference and Change default config Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant