Parsley 5.0 #223
Draft
Parsley 5.0 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CalleeSave` is a problematic instruction that has possible race-conditions, as well as being badly behaved for recursively bound `flatMap`s. This system was designed to allow for references to reuse slots in the array when necessary. However, it is much safer to think of all the references in the universe being independent; the problem, of course, is that not all of these references are visible at the top-level, so there is likely not enough space to accommodate them. This PR reworks things so that the `Context` feeds back information to a soon-to-be-generated `flatMap` body about the currently largest residency found for references. The `flatMap` will always allocate its references above this, and emit a new instruction that *just* resizes the refs array. It is possible that global references find themselves occupying the same slot as another if it was used across two parsers, and this is more explicitly checked now up-front in the allocator. Whereas before only if a reference was out of range would it crash, now it will crash immediately as soon as a clash for the references of a parser appear: this avoids the undefined behaviour where two references would write over each other. In all, a better system. Fixes #241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsley
5.0.0Staging PRThis is the PR encompassing all changes for version
5.0.0. As this is substantial new functionality, it will be previewed incrementally starting with5.0.0-M1. When the API is completed and seems reasonable,5.0.0-RC1will be released to allow for testing of the release, full documentation, and ironing out of bugs. When the release is stable enough, it will be merged intomasterand5.0.0will be officially released.High-Level Changes
This release aims to consolidate the library ready for long-term stability. This will include adjusting the API to allow for more forwards-compatible evolution.
Low-Level Changes
Major Changes
None.
Minor Changes
None.
Patch Changes
None.
Internal Changes
None.
Release Checklist
5.0.0-M14.5.05.0.0-M25.0.0-M3labelSymbolPunctuationdoes nothing #227labelSymbolto replace the sub-configurations (which are deprecated for future removal, but still hooked in for back-compat for next few weeks)5.0.0-M4mapFilterMsgcombinator toparsley.errors.combinator5.0.0-M5Reasons used forlabelConfigresult in no error labels5.0.0-M6SpecializedFilteratomicChoiceFailureas a simple case classErrorBuilder.formattobuildErrorBuilder.lineInfo5.0.0-M7- Anton's Milestoneparsley-debugparsley-debug.parsley.tokenpackages some more.parsley.syntax.allandparsley.quickstartobjects to cut down on imports.5.0.0-M8- native 0.55.0.0-M9parsley.debugmade into a packageparsley-debug'sdebuggable->debugdebug.frontend.DebugFrontend->debug.DebugView, withReusableFrontend->DebugView.Reusableand similar forSingleUse.attachDebuggercombinators, I think we'll go ahead with view-only debugging for now.PartialFunction[Any, Boolean]for ergonomics.debug.util.Collector, it's a shame we'll never be able to remove it completely because ofparsley.debuggable's view on it.5.0.0-RC15.0.0README.mdupdated to reflect new versionprivate [parsley]members orparsley.internal.Milestone Migration Guide
As each milestone release may choose to make binary incompatible changes, any necessary migration required to get from one milestone to the next will be tracked here.
4.5.05.0.0-M15.0.0-M15.0.0-M25.0.0-M25.0.0-M3ErrorConfigfor symbols are deprecated, uselabelSymbolinstead5.0.0-M35.0.0-M45.0.0-M45.0.0-M55.0.0-M55.0.0-M6build, notformatforErrorBuilder.ErrorBuilder.lineInfonow has alineNumargument.SpecialisedFilterand its children are now spelt with az. TheatomicChoicecombinator has been removed, reconsider your life choices if you're using it.5.0.0-M65.0.0-M7token.predicatepackage has been removed,token.descriptionsis now a flat package too.5.0.0-M75.0.0-M85.0.0-M85.0.0-M9parsley.debugis now a package,parsley-debug'sdebuggerpackage has been merged into that. Various name changes withinparsley-debug, which should hopefully make it a bit clearer how it should be used.